-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: overdraft function #14
Open
ascandone
wants to merge
7
commits into
main
Choose a base branch
from
feat/experiment-overdraft-function
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+362
−95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14 +/- ##
==========================================
+ Coverage 63.33% 63.34% +0.01%
==========================================
Files 29 29
Lines 6395 6461 +66
==========================================
+ Hits 4050 4093 +43
- Misses 2167 2187 +20
- Partials 178 181 +3 ☔ View full report in Codecov by Sentry. |
ascandone
force-pushed
the
feat/experiment-overdraft-function
branch
from
November 21, 2024 02:35
c26bdb0
to
d619d6e
Compare
ascandone
force-pushed
the
feat/experiment-overdraft-function
branch
from
November 26, 2024 12:48
d619d6e
to
c5dcc88
Compare
ascandone
force-pushed
the
feat/experiment-overdraft-function
branch
from
November 27, 2024 14:47
8f1fd3a
to
be5b6d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an overdraft() function which returns the absolute value of the negative balance of the given account and currency; 0 if overdraft is non negative (see tests as reference)
This is a new numscript functionality which is not implemented in the current machine implementation; thus the functionality is under the
experimental-overdraft-function
feature flag