Add ReadRef, WriteRef, [Unpack & UnpackGeneric] (commented because of mutual dependency in impl_values.v) definitions. #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Value Global Instance
clarus
reviewed
Nov 13, 2024
Comment on lines
1082
to
1088
| | Bytecode.WriteRef => | ||
| letS!? reference := liftS! Interpreter.Lens.lens_state_self ( | ||
| liftS! Interpreter.Lens.lens_operand_stack $ Stack.Impl_Stack.pop_as Reference.t) in | ||
| letS!? value := liftS! Interpreter.Lens.lens_state_self ( | ||
| liftS! Interpreter.Lens.lens_operand_stack Stack.Impl_Stack.pop) in | ||
| letS!? _ := returnS! $ Impl_ReferenceImpl.write_ref reference value in | ||
| returnS! $ Result.Ok InstrRet.Ok |
There was a problem hiding this comment.
With one more level of indentation
| @@ -1,4 +1,6 @@ | |||
| Require Import CoqOfRust.CoqOfRust. | |||
| Require Import Coq.Lists.List. | |||
There was a problem hiding this comment.
We should not need this line, as we prefix all the calls to list functions with List. to help to know where they are from when reading the code.
| @@ -1,4 +1,6 @@ | |||
| Require Import CoqOfRust.CoqOfRust. | |||
| Require Import Coq.Lists.List. | |||
| Import ListNotations. | |||
There was a problem hiding this comment.
These notations should already be in Require Import CoqOfRust.CoqOfRust..
| @@ -7,6 +9,7 @@ Import simulations.M.Notations. | |||
| Require CoqOfRust.move_sui.simulations.move_binary_format.errors. | |||
| Module PartialVMResult := errors.PartialVMResult. | |||
| Module PartialVMError := errors.PartialVMError. | |||
| Import PartialVMResult. | |||
There was a problem hiding this comment.
I think we should avoid this Import otherwise it is too unclear where the calls are from.
| Module ReferenceImpl. | ||
| Inductive t : Set := | ||
| | IndexedRef : IndexedRef.t -> t | ||
| | ContainerRef : ContainerRef.t -> t | ||
| . | ||
|
|
There was a problem hiding this comment.
I think we should not have an empty line at the end of modules actually, even if this is often the case in our current code.
|
I will put these changes to effect. What about the L. 687 in values_impl.v ? |
clarus
approved these changes
Nov 13, 2024
19 tasks
0xMushow
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.