CID 248412: Explicit null dereferenced (FORWARD_NULL)

18. var_deref_model: Passing null pointer this->m_runnableJob to run, which dereferences it. (The dereference happens because this is a virtual function call.)
forkkit · Sep 26, 2019 · eeee0ea · eeee0ea
1 parent cc80eb9
commit eeee0ea
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/libs/image/kis_update_job_item.h b/libs/image/kis_update_job_item.h
@@ -88,12 +88,11 @@ class KisUpdateJobItem :  public QObject, public QRunnable
                 KIS_ASSERT(m_atomicType == Type::STROKE ||
                            m_atomicType == Type::SPONTANEOUS);
 
-                m_runnableJob->run();
+                if (m_runnableJob) m_runnableJob->run();
             }
 
             setDone();
 
-
             m_updaterContext->doSomeUsefulWork();
 
             // may flip the current state from Waiting -> Running again