Skip to content

Commit

Permalink
chore: merge main
Browse files Browse the repository at this point in the history
  • Loading branch information
shetzel committed Aug 19, 2024
2 parents 7ac8c82 + 83228e8 commit fb50486
Show file tree
Hide file tree
Showing 52 changed files with 2,043 additions and 2,504 deletions.
2,039 changes: 443 additions & 1,596 deletions CHANGELOG.md

Large diffs are not rendered by default.

10 changes: 10 additions & 0 deletions HANDBOOK.md
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,16 @@ Be careful when instantiating classes (ex: ComponentSet) that will default a Reg

**Updating presets** If you do need to update a preset to make a breaking change, it's better to copy it to a new preset and give it a unique name (ex: `decomposeFooV2`). This preserves the existing behavior for existing projects with the old preset.

Presets **can** remove strings from the default metadataRegistry by setting values to empty string ex:

```json
{
"childTypes": {
"somethingThatIsUsuallyAChild": ""
}
}
```

### Querying registry data

While it’s perfectly fine to reference the registry export directly, the `RegistryAccess` class was created to make accessing the object a bit more streamlined. Querying types and searching the registry is oftentimes easier and cleaner this way and contains built-in checking for whether or not a metadata type exists. Here’s a comparison of using each:
Expand Down
Loading

2 comments on commit fb50486

@svc-cli-bot
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: fb50486 Previous: c46371f Ratio
eda-componentSetCreate-linux 232 ms 229 ms 1.01
eda-sourceToMdapi-linux 2406 ms 2357 ms 1.02
eda-sourceToZip-linux 1946 ms 1857 ms 1.05
eda-mdapiToSource-linux 2977 ms 3048 ms 0.98
lotsOfClasses-componentSetCreate-linux 435 ms 437 ms 1.00
lotsOfClasses-sourceToMdapi-linux 3804 ms 3693 ms 1.03
lotsOfClasses-sourceToZip-linux 3237 ms 3053 ms 1.06
lotsOfClasses-mdapiToSource-linux 3683 ms 3540 ms 1.04
lotsOfClassesOneDir-componentSetCreate-linux 762 ms 745 ms 1.02
lotsOfClassesOneDir-sourceToMdapi-linux 6693 ms 6377 ms 1.05
lotsOfClassesOneDir-sourceToZip-linux 5871 ms 5579 ms 1.05
lotsOfClassesOneDir-mdapiToSource-linux 6732 ms 6333 ms 1.06

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: fb50486 Previous: c46371f Ratio
eda-componentSetCreate-win32 611 ms 609 ms 1.00
eda-sourceToMdapi-win32 4169 ms 4424 ms 0.94
eda-sourceToZip-win32 2968 ms 2922 ms 1.02
eda-mdapiToSource-win32 5662 ms 5726 ms 0.99
lotsOfClasses-componentSetCreate-win32 1188 ms 1143 ms 1.04
lotsOfClasses-sourceToMdapi-win32 7663 ms 7605 ms 1.01
lotsOfClasses-sourceToZip-win32 4968 ms 4882 ms 1.02
lotsOfClasses-mdapiToSource-win32 7857 ms 7790 ms 1.01
lotsOfClassesOneDir-componentSetCreate-win32 2109 ms 2085 ms 1.01
lotsOfClassesOneDir-sourceToMdapi-win32 13786 ms 13780 ms 1.00
lotsOfClassesOneDir-sourceToZip-win32 9187 ms 9059 ms 1.01
lotsOfClassesOneDir-mdapiToSource-win32 13928 ms 14045 ms 0.99

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.