test: revert ut assertions, ensure order

forcedotcom · Aug 1, 2024 · 174a93b · 174a93b · svc-cli-bot · Aug 1, 2024
1 parent 40f11b2
commit 174a93b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/test/collections/componentSet.test.ts b/test/collections/componentSet.test.ts
@@ -471,7 +471,7 @@ describe('ComponentSet', () => {
         const missingIndex = expected.findIndex((c) => c.fullName === 'c');
         expected.splice(missingIndex, 1);
 
-        expect(result).to.have.deep.members(expected);
+        expect(result).to.deep.equal(expected);
       });
 
       it('should resolve wildcard members by default', async () => {

diff --git a/test/resolve/metadataResolver.test.ts b/test/resolve/metadataResolver.test.ts
@@ -287,7 +287,7 @@ describe('MetadataResolver', () => {
             allowContent: false,
           },
         ]);
-        expect(access.getComponentsFromPath(path)).to.have.deep.members(xmlInFolder.COMPONENTS);
+        expect(access.getComponentsFromPath(path)).to.deep.equal(xmlInFolder.COMPONENTS);
       });
 
       it('Should determine type for folder files', () => {
@@ -453,9 +453,7 @@ describe('MetadataResolver', () => {
             componentMappings,
           },
         ]);
-        expect(resolver.getComponentsFromPath(xmlInFolder.COMPONENT_FOLDER_PATH)).to.have.deep.members(
-          xmlInFolder.COMPONENTS
-        );
+        expect(resolver.getComponentsFromPath(xmlInFolder.COMPONENT_FOLDER_PATH)).to.deep.equal(xmlInFolder.COMPONENTS);
       });
 
       it('Should walk all file and directory children', () => {
@@ -523,7 +521,7 @@ describe('MetadataResolver', () => {
             ],
           },
         ]);
-        expect(access.getComponentsFromPath(apexDir)).to.have.deep.members([
+        expect(access.getComponentsFromPath(apexDir)).to.deep.equal([
           matchingContentFile.COMPONENT,
           reportComponent,
           apexComponentB,
@@ -552,7 +550,7 @@ describe('MetadataResolver', () => {
             ],
           },
         ]);
-        expect(access.getComponentsFromPath(mixedContentInFolder.COMPONENT_FOLDER_PATH)).to.have.deep.members([
+        expect(access.getComponentsFromPath(mixedContentInFolder.COMPONENT_FOLDER_PATH)).to.deep.equal([
           mixedContentInFolder.COMPONENTS[0],
           mixedContentInFolder.COMPONENTS[1],
         ]);
@@ -815,7 +813,7 @@ describe('MetadataResolver', () => {
 
         const result = resolver.getComponentsFromPath(decomposedtoplevel.DECOMPOSED_TOP_LEVEL_COMPONENT_PATH, filter);
 
-        expect(result).to.have.deep.members(children);
+        expect(result).to.deep.equal(children);
       });
 
       it('should resolve directory component if in filter', () => {
Benchmark suite	Current: `174a93b`	Previous: `e671e8a`	Ratio
`eda-componentSetCreate-linux`	`236` ms	`185` ms	`1.28`
`eda-sourceToMdapi-linux`	`2332` ms	`2367` ms	`0.99`
`eda-sourceToZip-linux`	`1818` ms	`1864` ms	`0.98`
`eda-mdapiToSource-linux`	`2814` ms	`2970` ms	`0.95`
`lotsOfClasses-componentSetCreate-linux`	`427` ms	`377` ms	`1.13`
`lotsOfClasses-sourceToMdapi-linux`	`3774` ms	`3727` ms	`1.01`
`lotsOfClasses-sourceToZip-linux`	`3139` ms	`3183` ms	`0.99`
`lotsOfClasses-mdapiToSource-linux`	`3567` ms	`3572` ms	`1.00`
`lotsOfClassesOneDir-componentSetCreate-linux`	`730` ms	`645` ms	`1.13`
`lotsOfClassesOneDir-sourceToMdapi-linux`	`6572` ms	`6517` ms	`1.01`
`lotsOfClassesOneDir-sourceToZip-linux`	`5773` ms	`5683` ms	`1.02`
`lotsOfClassesOneDir-mdapiToSource-linux`	`6385` ms	`6521` ms	`0.98`
Benchmark suite	Current: `174a93b`	Previous: `e671e8a`	Ratio
`eda-componentSetCreate-win32`	`687` ms	`428` ms	`1.61`
`eda-sourceToMdapi-win32`	`4185` ms	`4275` ms	`0.98`
`eda-sourceToZip-win32`	`3224` ms	`2931` ms	`1.10`
`eda-mdapiToSource-win32`	`6072` ms	`5728` ms	`1.06`
`lotsOfClasses-componentSetCreate-win32`	`1280` ms	`877` ms	`1.46`
`lotsOfClasses-sourceToMdapi-win32`	`8162` ms	`7339` ms	`1.11`
`lotsOfClasses-sourceToZip-win32`	`5429` ms	`4753` ms	`1.14`
`lotsOfClasses-mdapiToSource-win32`	`8361` ms	`7568` ms	`1.10`
`lotsOfClassesOneDir-componentSetCreate-win32`	`2308` ms	`1482` ms	`1.56`
`lotsOfClassesOneDir-sourceToMdapi-win32`	`14636` ms	`13470` ms	`1.09`
`lotsOfClassesOneDir-sourceToZip-win32`	`9752` ms	`8615` ms	`1.13`
`lotsOfClassesOneDir-mdapiToSource-win32`	`14804` ms	`13679` ms	`1.08`