Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEW (CodeAnalyzer): @W-13569501@: 3.16.0 Release Work #1158

Merged
merged 36 commits into from
Aug 25, 2023
Merged

Conversation

teresa-allen-sfdc
Copy link
Collaborator

  • release summary
  • new Graph Engine rule
  • promoted from pilot to GA, two rules
  • new VS code extension doc

@jfeingold35 jfeingold35 changed the base branch from dev to docdev August 24, 2023 17:22
Comment on lines 100 to 101
url: /v3.x/code-analyzer-vs-code-extension
new: true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The url and new lines need to be indented with two spaces instead of four.

@@ -0,0 +1,144 @@
# Salesforce Code Analyzer Visual Studio Code Extension (Beta)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this header line and replace it with:

---
title: Salesforce Code Analyzer Visual Studio Code Extension (Beta)
lang: en
redirect_from: /en/code-analyzer-vs-code-extension
---

* [RetireJS](https://retirejs.github.io/retire.js/)
* [Salesforce Graph Engine](https://forcedotcom.github.io/sfdx-scanner/en/v3.x/salesforce-graph-engine/introduction/) (Generally Available rules only)

You can also enable the extension to scan these languages:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's my fault for not catching this earlier, but "You can also enable the extension to scan these languages" is slightly misleading, as it suggests that the act of enabling the extension allows the scanning of those languages. In actuality, the languages need to be enabled within the plug-in's settings. It may be beneficial to link to the relevant part of the FAQ, sfdx-scanner/en/v3.x/faq/#q-how-do-i-enable-engine-xs-default-rules-for-language-y.


Regardless of which option you chose, the progress bar notifies you that the scan of your current file is active.

![The VS Code progress bar displaying a Code Analyzer is analyzing targets message.](/docs/assets/images/vscode-images/AnalyzingTargets.png)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change this link to ./assets/images/vscode-images/AnalyzingTargets.png.


When your scan is complete, click the scan summary in the progress bar (1). You see a scrollable list of violations that Code Analyzer found (2).

![alt text: Sample VS Code code and Salesforce Code Analyzer scan results](/docs/assets/images/vscode-images/ScanSummary.png)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change this link to ./assets/images/vscode-images/ScanSummary.png


*Example*: /Users/MyUsername/Code/sfdx-scanner/

![alt text: Salesforce Code Analyzer Settings with Code Analyzer > PMD Custom Config File section and a sample file location](/docs/assets/images/vscode-images/SettingsTwoBubbles.png)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace this link with ./assets/images/vscode-images/SettingsTwoBubbles.png.


The progress bar notifies you that the scan of your current file is active.

![alt text: The VS Code progress bar displaying a Scanning targets notification.](/docs/assets/images/vscode-images/RunningGraphEngineAnalysis.png)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace this link with ./assets/images/vscode-images/RunningGraphEngineAnalysis.png.


When your scan is complete, a new tab opens with an HTML display of the violations found.

![alt text: A sample Salesforce Graph Engine pop-up window with an html list of violations found](/docs/assets/images/vscode-images/GraphEngineResultsBlur.png)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace this link with ./assets/images/vscode-images/GraphEngineResultsBlur.png.


* NEW (CodeAnalyzer): We made some updates to the RetireJS vulnerability database.
* NEW (GraphEngine): To improve your code performance, we added one new pilot path-based Salesforce Graph Engine rule: PerformNullCheckOnSoqlVariables. This rule determines when a variable is noticed in the WHERE clause of a SOQL query and is missing a null check.
* NEW (GraphEngine): Two recently released Graph Engine pilot rules are now generally available: AvoidDatabaseOperationInLoop and UseWithSharingOnDatabaseOperation.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to use sub-bullets for the two rules, the way we did in the 3.15.0 release note that announced their introduction?

* NEW (CodeAnalyzer): We made some updates to the RetireJS vulnerability database.
* NEW (GraphEngine): To improve your code performance, we added one new pilot path-based Salesforce Graph Engine rule: PerformNullCheckOnSoqlVariables. This rule determines when a variable is noticed in the WHERE clause of a SOQL query and is missing a null check.
* NEW (GraphEngine): Two recently released Graph Engine pilot rules are now generally available: AvoidDatabaseOperationInLoop and UseWithSharingOnDatabaseOperation.
* NEW (CodeAnalyzer): To scan your code easily, we released the [Salesforce Code Analyzer Visual Studio Code extension (beta)](https://forcedotcom.github.io/sfdx-scanner/en/v3.x/code-analyzer-vs-code-extension).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the link to ./en/v3.x/code-analyzer-vs-code-extension

* [RetireJS](https://retirejs.github.io/retire.js/)
* [Salesforce Graph Engine](https://forcedotcom.github.io/sfdx-scanner/en/v3.x/salesforce-graph-engine/introduction/) (Generally Available rules only)

Additionhally, you can also [enable]([https://forcedotcom.github.io/sfdx-scanner/en/v3.x/faq/#q-how-do-i-enable-engine-xs-default-rules-for-language-y]) these languages in Salesforce Code Analyzer settings:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jfeingold35 I updated this sentence per your comment. But I'm confused: if the user wants to run Code Analyzer on Java or XML, can they use the VS Code extension? If they have to change the setting via the CLI and can't use the VS Code extension, then this paragraph and two bullet points should be removed. Also, see the thread on the core release note - it's near ready to check in, so I'd appreciate your input there, too.

https://docs.google.com/document/d/1DrCR4CAgM0yrlbmCi3eWnbtoZlDSupXc2n4pvbLfXoY/edit?usp=sharing

@@ -12,7 +12,7 @@ Use Code Analyzer VS Code extension (beta) to scan multiple languages:
* [RetireJS](https://retirejs.github.io/retire.js/)
* [Salesforce Graph Engine](https://forcedotcom.github.io/sfdx-scanner/en/v3.x/salesforce-graph-engine/introduction/) (Generally Available rules only)

You can also enable the extension to scan these languages:
You can also [enable]([https://forcedotcom.github.io/sfdx-scanner/en/v3.x/faq/#q-how-do-i-enable-engine-xs-default-rules-for-language-y]) these languages in Salesforce Code Analyzer settings:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link is broken.

Suggested change
You can also [enable]([https://forcedotcom.github.io/sfdx-scanner/en/v3.x/faq/#q-how-do-i-enable-engine-xs-default-rules-for-language-y]) these languages in Salesforce Code Analyzer settings:
You can also [enable](./en/v3.x/faq/#q-how-do-i-enable-engine-xs-default-rules-for-language-y) these languages in Salesforce Code Analyzer settings:

@@ -1,4 +1,4 @@
# Salesforce Code Analyzer Visual Studio Code Extension (Beta)
--- title: Salesforce Code Analyzer Visual Studio Code Extension (Beta) lang: en redirect_from: /en/code-analyzer-vs-code-extension ---
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dashes and the properties all need to be on separate lines.

Suggested change
--- title: Salesforce Code Analyzer Visual Studio Code Extension (Beta) lang: en redirect_from: /en/code-analyzer-vs-code-extension ---
---
title: Salesforce Code Analyzer Visual Studio Code Extension (Beta)
lang: en
redirect_from: /en/code-analyzer-vs-code-extension
---

@jfeingold35 jfeingold35 merged commit ab0e574 into docdev Aug 25, 2023
2 checks passed
@teresa-allen-sfdc teresa-allen-sfdc deleted the teresa-docdev branch September 26, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants