Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code cleanup #1358

Merged
merged 1 commit into from
Oct 23, 2024
Merged

code cleanup #1358

merged 1 commit into from
Oct 23, 2024

Conversation

ashitsalesforce
Copy link
Contributor

  • all tests are subclasses of ConfigTestBase or its subclasses, thereby ensuring that AppConfig is instantiated for every test.
  • AppConfig.initializeAppConfig() is called from AppConfig.getInstance(). No need to call it explicitly from outside.
  • Encryption code parses command line options in a more flexible manner to support debug flag

@ashitsalesforce
code cleanup
68a2d47 
- all tests are subclasses of ConfigTestBase or its subclasses, thereby ensuring that AppConfig is instantiated for every test.
- AppConfig.initializeAppConfig() is called from AppConfig.getInstance(). No need to call it explicitly from outside.
- Encryption code parses command line options in a more flexible manner to support debug flag
@ashitsalesforce ashitsalesforce merged commit 56cf6d8 into forcedotcom:master Oct 23, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ashitsalesforce