Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make fake_bind compatible to runic. #3106

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

j-fu
Copy link
Contributor

@j-fu j-fu commented Nov 25, 2024

Runic is a new "runic" formatter for Julia code.
Due to peculiarities of implementation, format toggling is better handeled by wrapping around whole functions or macros, see

See fredrikekre/Runic.jl#107 (comment)

So in order to make Pluto notebooks invariant under runic formatting I propose to modify fake_bind accordingly.

Try this Pull Request!

Open Julia and type:

julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/j-fu/Pluto.jl", rev="runic_fake_bind")
julia> using Pluto

@fredrikekre
Copy link
Contributor

(Simply adding return in front of the quote would be an alternative fix if you don't want to move the comments to the outside of the macro.)

@fonsp
Copy link
Owner

fonsp commented Nov 25, 2024

Let's go with the return then! See #3072 for previous discussion

@fonsp
Copy link
Owner

fonsp commented Dec 13, 2024

Can you update the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants