Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecations #3051

Merged
merged 6 commits into from
Oct 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/Configuration.jl
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ const AUTO_RELOAD_FROM_FILE_DEFAULT = false
const AUTO_RELOAD_FROM_FILE_COOLDOWN_DEFAULT = 0.4
const AUTO_RELOAD_FROM_FILE_IGNORE_PKG_DEFAULT = false
const NOTEBOOK_DEFAULT = nothing
const INIT_WITH_FILE_VIEWER_DEFAULT = false
const SIMULATED_LAG_DEFAULT = 0.0
const SIMULATED_PKG_LAG_DEFAULT = 0.0
const INJECTED_JAVASCRIPT_DATA_URL_DEFAULT = "data:text/javascript;base64,"
Expand All @@ -77,7 +76,6 @@ The HTTP server options. See [`SecurityOptions`](@ref) for additional settings.
- `auto_reload_from_file_cooldown::Real = $AUTO_RELOAD_FROM_FILE_COOLDOWN_DEFAULT` Experimental, will be removed
- `auto_reload_from_file_ignore_pkg::Bool = $AUTO_RELOAD_FROM_FILE_IGNORE_PKG_DEFAULT` Experimental flag, will be removed
- `notebook::Union{Nothing,String} = $NOTEBOOK_DEFAULT` Optional path of notebook to launch at start
- `init_with_file_viewer::Bool = $INIT_WITH_FILE_VIEWER_DEFAULT`
- `simulated_lag::Real=$SIMULATED_LAG_DEFAULT` (internal) Extra lag to add to our server responses. Will be multiplied by `0.5 + rand()`.
- `simulated_pkg_lag::Real=$SIMULATED_PKG_LAG_DEFAULT` (internal) Extra lag to add to operations done by Pluto's package manager. Will be multiplied by `0.5 + rand()`.
- `injected_javascript_data_url::String = "$INJECTED_JAVASCRIPT_DATA_URL_DEFAULT"` (internal) Optional javascript injectables to the front-end. Can be used to customize the editor, but this API is not meant for general use yet.
Expand All @@ -100,7 +98,6 @@ The HTTP server options. See [`SecurityOptions`](@ref) for additional settings.
auto_reload_from_file_cooldown::Real = AUTO_RELOAD_FROM_FILE_COOLDOWN_DEFAULT
auto_reload_from_file_ignore_pkg::Bool = AUTO_RELOAD_FROM_FILE_IGNORE_PKG_DEFAULT
notebook::Union{Nothing,String,Vector{<:String}} = NOTEBOOK_DEFAULT
init_with_file_viewer::Bool = INIT_WITH_FILE_VIEWER_DEFAULT
simulated_lag::Real = SIMULATED_LAG_DEFAULT
simulated_pkg_lag::Real = SIMULATED_PKG_LAG_DEFAULT
injected_javascript_data_url::String = INJECTED_JAVASCRIPT_DATA_URL_DEFAULT
Expand Down Expand Up @@ -293,7 +290,6 @@ function from_flat_kwargs(;
auto_reload_from_file_cooldown::Real = AUTO_RELOAD_FROM_FILE_COOLDOWN_DEFAULT,
auto_reload_from_file_ignore_pkg::Bool = AUTO_RELOAD_FROM_FILE_IGNORE_PKG_DEFAULT,
notebook::Union{Nothing,String,Vector{<:String}} = NOTEBOOK_DEFAULT,
init_with_file_viewer::Bool = INIT_WITH_FILE_VIEWER_DEFAULT,
simulated_lag::Real = SIMULATED_LAG_DEFAULT,
simulated_pkg_lag::Real = SIMULATED_PKG_LAG_DEFAULT,
injected_javascript_data_url::String = INJECTED_JAVASCRIPT_DATA_URL_DEFAULT,
Expand Down Expand Up @@ -342,7 +338,6 @@ function from_flat_kwargs(;
auto_reload_from_file_cooldown,
auto_reload_from_file_ignore_pkg,
notebook,
init_with_file_viewer,
simulated_lag,
simulated_pkg_lag,
injected_javascript_data_url,
Expand Down
2 changes: 0 additions & 2 deletions src/analysis/DependencyCache.jl
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ function downstream_cells_map(cell::Cell, topology::NotebookTopology)::Dict{Symb
for sym in defined_symbols
)
end
@deprecate downstream_cells_map(cell::Cell, notebook::Notebook) downstream_cells_map(cell, notebook.topology)

_is_anon_function_name(s::Symbol) = startswith(String(s), "__ExprExpl_anon__")

Expand All @@ -30,7 +29,6 @@ function upstream_cells_map(cell::Cell, topology::NotebookTopology)::Dict{Symbol
for sym in referenced_symbols
)
end
@deprecate upstream_cells_map(cell::Cell, notebook::Notebook) upstream_cells_map(cell, notebook.topology)

"Fills cell dependency information for display in the GUI"
function update_dependency_cache!(cell::Cell, topology::NotebookTopology)
Expand Down
5 changes: 0 additions & 5 deletions src/evaluation/WorkspaceManager.jl
Original file line number Diff line number Diff line change
Expand Up @@ -606,11 +606,6 @@ function move_vars(
)
end

# TODO: delete me
@deprecate(
delete_vars(args...; kwargs...),
move_vars(args...; kwargs...)
)

"""
```julia
Expand Down
11 changes: 0 additions & 11 deletions src/notebook/Notebook.jl
Original file line number Diff line number Diff line change
Expand Up @@ -129,17 +129,6 @@ function PlutoDependencyExplorer.topological_order(notebook::Notebook)
end
end

function PlutoDependencyExplorer.where_referenced(notebook::Notebook, topology::NotebookTopology, something)
# can't use @deprecate on an overload
@warn "Deprecated, drop the notebook argument"
PlutoDependencyExplorer.where_referenced(topology, something)
end
function PlutoDependencyExplorer.where_assigned(notebook::Notebook, topology::NotebookTopology, something)
# can't use @deprecate on an overload
@warn "Deprecated, drop the notebook argument"
PlutoDependencyExplorer.where_assigned(topology, something)
end

emptynotebook(args...) = Notebook([Cell()], args...)

function sample_notebook(name::String)
Expand Down
4 changes: 0 additions & 4 deletions src/webserver/SessionActions.jl
Original file line number Diff line number Diff line change
Expand Up @@ -213,10 +213,6 @@ end

"Create a new empty notebook inside `session::ServerSession`. Returns the `Notebook`."
function new(session::ServerSession; run_async=true, notebook_id::UUID=uuid1())
if session.options.server.init_with_file_viewer
@error "DEPRECATED: init_with_file_viewer has been removed."
end

notebook = if session.options.compiler.sysimage === nothing
emptynotebook()
else
Expand Down
Loading