with_js_link with stronger invalidation #2780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try this Pull Request!Open Julia and type: julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/fonsp/Pluto.jl", rev="with_js_link-with-proper-invalidation")
julia> using Pluto |
fonsp
changed the base branch from
main
to
AbstractPlutoDingetjes.Display.with_js_link
…js_link-with-proper-invalidation
…js_link-with-proper-invalidation
14 tasks
…js_link-with-proper-invalidation
…js_link-with-proper-invalidation
fonsp
merged commit a7d146c
into
AbstractPlutoDingetjes.Display.with_js_link
3 of 16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, all js links get invalidated when the cell they appear in becomes queued. This is necessary because one of the dependencies of the cell can define a function whose methods are being deleted by Pluto.
But it's a lot of new code for a rare issue.
Maybe this solution can also be used to solve JuliaPluto/PlutoHooks.jl#15