Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📰 Preview in frontmatter editor #2688

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Conversation

fonsp
Copy link
Owner

@fonsp fonsp commented Oct 30, 2023

Schermopname.2023-10-30.om.13.23.48.mov

@fonsp fonsp added the frontend Concerning the HTML editor label Oct 30, 2023
@github-actions
Copy link
Contributor

Try this Pull Request!

Open Julia and type:

julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/fonsp/Pluto.jl", rev="featured-card-preview-in-frontmatter")
julia> using Pluto

@fonsp fonsp added the publishing Notebooks as static documents on the web label Oct 30, 2023
@fonsp fonsp merged commit 52e471d into main Oct 30, 2023
4 checks passed
@fonsp fonsp deleted the featured-card-preview-in-frontmatter branch October 30, 2023 12:55
@Pangoraw
Copy link
Collaborator

Pangoraw commented Oct 30, 2023

Nice! ✨ it would be cool to be able to embed this as an og image in the static HTML export to have a preview when sharing a link to a notebook.

@fonsp
Copy link
Owner Author

fonsp commented Oct 30, 2023

With https://vercel.com/docs/functions/edge-functions/og-image-generation ! Seems really cool but also maybe too much work... Maybe @ctrekker is interested in adding this to glass one day?

@ctrekker
Copy link
Collaborator

ctrekker commented Oct 30, 2023

Looks like a nice opportunity to make links cleaner when shared! Would you mind if I use the same card styling for published notebooks in Glass? The default behavior isn't very clean currently (see https://glassnotebook.io/r/R8vQF4q7Y08OyKT8Z3vvP/ for example), and it would be nice to mimic the card design language already used on the Pluto landing page

@fonsp
Copy link
Owner Author

fonsp commented Oct 31, 2023

Of course!! 💛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Concerning the HTML editor publishing Notebooks as static documents on the web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants