Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show error message when statefile fails to load #2686

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

fonsp
Copy link
Owner

@fonsp fonsp commented Oct 30, 2023

image

You can test this PR by clicking on a featured notebook, and then editing the URL to make the statefile a bad URL.

@fonsp fonsp added frontend Concerning the HTML editor online deployment About deploying to binder, heroku, self-hosted labels Oct 30, 2023
@github-actions
Copy link
Contributor

Try this Pull Request!

Open Julia and type:

julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/fonsp/Pluto.jl", rev="statefile-load-error-message")
julia> using Pluto

@fonsp
Copy link
Owner Author

fonsp commented Oct 30, 2023

@pankgeorg this is probably compatible with JH but you might want to make sure. It just adds a .catch to the promise returned by your overloaded get_statefile function.

@fonsp fonsp merged commit 3b3d56c into main Oct 30, 2023
4 checks passed
@fonsp fonsp deleted the statefile-load-error-message branch October 30, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Concerning the HTML editor online deployment About deploying to binder, heroku, self-hosted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant