Skip to content

Commit

Permalink
🧱 LOAD_PATH special case
Browse files Browse the repository at this point in the history
  • Loading branch information
fonsp committed Aug 30, 2020
1 parent d402723 commit 183ec96
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 5 deletions.
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name = "Pluto"
uuid = "c3e4b0f8-55cb-11ea-2926-15256bba5781"
license = "MIT"
authors = ["Fons van der Plas <[email protected]>", "MikoÅ‚aj Bochenski <[email protected]>"]
version = "0.11.9"
version = "0.11.10"

[deps]
Base64 = "2a0f44e3-6c83-55bd-87e4-b1978d98bd5f"
Expand Down
11 changes: 7 additions & 4 deletions src/analysis/Topology.jl
Original file line number Diff line number Diff line change
Expand Up @@ -127,14 +127,17 @@ end
This is used to treat reactive dependencies between cells that cannot be found using static code anylsis."""
function cell_precedence_heuristic(topology::NotebookTopology, cell::Cell)::Number
if !isempty(cell.module_usings)
# always do `using X` before other cells, because we don't (yet) know which cells depend on it (we only know it with `import X` and `import X: y, z`)
if :LOAD_PATH ∈ topology[cell].references
# https://github.com/fonsp/Pluto.jl/issues/323
1
elseif !isempty(cell.module_usings)
# always do `using X` before other cells, because we don't (yet) know which cells depend on it (we only know it with `import X` and `import X: y, z`)
2
elseif [:include] ∈ topology[cell].funccalls
# https://github.com/fonsp/Pluto.jl/issues/193
# because we don't (yet) know which cells depend on it
2
else
3
else
4
end
end

3 comments on commit 183ec96

@fonsp
Copy link
Owner Author

@fonsp fonsp commented on 183ec96 Aug 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fonsp
Copy link
Owner Author

@fonsp fonsp commented on 183ec96 Aug 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register()

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/20531

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.11.10 -m "<description of version>" 183ec965380606fcd06cdf4215e1eef1967ccd63
git push origin v0.11.10

Please sign in to comment.