Skip to content

Commit

Permalink
remove compat stuff
Browse files Browse the repository at this point in the history
  • Loading branch information
fonsp committed Sep 20, 2023
1 parent 6cbc250 commit 0bb480f
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 19 deletions.
10 changes: 0 additions & 10 deletions src/Configuration.jl
Original file line number Diff line number Diff line change
Expand Up @@ -167,16 +167,6 @@ These options are not intended to be changed during normal use.
workspace_custom_startup_expr::Union{Nothing,String} = WORKSPACE_CUSTOM_STARTUP_EXPR_DEFAULT
end

# TODO: deprecated, remove me in the next breaking release
function Base.setproperty!(x::EvaluationOptions, property::Symbol, val)
if property === :workspace_custom_startup_expr && val isa Expr
@warn "Deprecated: workspace_custom_startup_expr should be a String, not an Expr."
setfield!(x, property, string(val))
else
setfield!(x, property, val)
end
end

const COMPILE_DEFAULT = nothing
const PKGIMAGES_DEFAULT = nothing
const COMPILED_MODULES_DEFAULT = nothing
Expand Down
10 changes: 1 addition & 9 deletions test/Configuration.jl
Original file line number Diff line number Diff line change
Expand Up @@ -128,16 +128,8 @@ end
@testset "disable mimetype via workspace_custom_startup_expr" begin
🍭 = ServerSession()
🍭.options.evaluation.workspace_use_distributed = true
🍭.options.evaluation.workspace_custom_startup_expr = quote
PlutoRunner.is_mime_enabled(m::MIME"application/vnd.pluto.tree+object") = false
end

# backwards compat: setting the value to an Expr should still work
@test 🍭.options.evaluation.workspace_custom_startup_expr isa String
@test occursin("PlutoRunner.is_mime_enabled", 🍭.options.evaluation.workspace_custom_startup_expr)

# normally you set it to a String
🍭.options.evaluation.workspace_custom_startup_expr = """
1 + 1
PlutoRunner.is_mime_enabled(m::MIME"application/vnd.pluto.tree+object") = false
"""

Expand Down

0 comments on commit 0bb480f

Please sign in to comment.