-
-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(build): optionally include version in released filename #3138
feat(build): optionally include version in released filename #3138
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Please fix the linting issues and we would appreciate if you could also prepare a PR in the docs repo accordingly 😊
You introduced another lint issue (!= instead of !==) by the latest commit. Please revert this to make the linter happy again. |
I may have misread or misunderstood lint. The !== was part of the original code. |
The original lint was telling you about the != in your new revision check. But you instead changed the line of the original code at another place which was introducing the new linter issue which you just should revert |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Docs added by fomantic/Fomantic-UI-Docs#522 |
@all-contributors please add @dreaming-augustin for code |
I've put up a pull request to add @dreaming-augustin! 🎉 |
Thank you @lubber-de for kindly merging my PR. Many thanks to you and to all the team for your long time contribution to Fomantic. |
Feature Request
Instead of releasing the files:
optionally release the files that include the version number and an optional revision string:
The advantage is to make clear which version is currently being used, and preventing the browser cache from running an obsolete version.
This pull-request is fully backward compatible as the default behaviour does not change at all.
The change is activated in semantic.json by adding the relevant fields:
I can update the patch if variable names need to be changed, or to add relevant documentation.
Fixes: dreaming-augustin#1