feat(search): support remove icon #3133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubber-de
added
type/feat
lubber-de
added
the
state/awaiting-docs
lubber-de
removed
the
state/awaiting-reviews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support remove icon for search module similar to dropdown module
Either via separate
remove iconor by using a nativeinput[type="search"]elementSidenote
I party reused code which was already implemented in 2015 but removed again (by accident or intentionally , only the original authors knows...)
That's why i also removed the left dead css code for
selection searchwhich never made it into any release and wasn't ever documented.Was commited by 4ea2514
... and immediatly removed again the same day by 6d34ae2
Testcase
https://jsfiddle.net/lubber/m2k9gn8o/126/