Reduce CSS by removing :not() selectors if variation is disabled #3118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubber-de
added
lang/css
lubber-de
removed
the
state/awaiting-reviews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A lot of
:not()css selectors are not needed when the related variation has been disabled and thus isn't compiledThis PR makes sure such selectors are removed upon compilation which reduces the generated css even more
For example if one disables circular step in
variation.variables(or in a custom site.variables)@variationStepCircular: false;then all the
:not(.circular)selectors can be removed as a.ui.circular.stepwon't exist after compilation, so there is no need to differentiate between them anymoreAs everything is enabled by default, this change does not affect anything and is completely backward compatible