Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dropdown,search): highlightMatches option #2963

Merged
merged 9 commits into from
Feb 9, 2024

Conversation

lubber-de
Copy link
Member

@lubber-de lubber-de commented Dec 14, 2023

Description

This PR adds a new option highlightMatches to dropdown and search module
Customizing the mark (background)-color is prepared in the LESS files for a custom theme, but disabled by default. (as the default would do nothing anyway)
I decided to leave this to each browsers defaults as its visuals are most familiar to usual browser search and the mark HTML tag uses the exact same styling.

  • Also fixed some typo inside search.less
  • Also made ignoreSearchCase available for search as we have the same for dropdown already

Testcase

https://jsfiddle.net/lubber/vjqe8f0d/8/

Screenshots

image
image

Closes

#2957

@lubber-de lubber-de added type/feat Any feature requests or improvements state/awaiting-reviews Pull requests which are waiting for reviews javascript Pull requests that update Javascript code labels Dec 14, 2023
@lubber-de lubber-de added this to the 2.9.4 milestone Dec 14, 2023
@lubber-de lubber-de added the state/awaiting-docs Pull requests which need doc changes/additions label Dec 14, 2023
src/definitions/modules/dropdown.js Dismissed Show resolved Hide resolved
@lubber-de lubber-de changed the title feat(dropdown): highlightMatches option feat(dropdown,search): highlightMatches option Feb 9, 2024
@lubber-de lubber-de merged commit 94e4e87 into fomantic:develop Feb 9, 2024
9 checks passed
@lubber-de lubber-de removed the state/awaiting-reviews Pull requests which are waiting for reviews label Feb 9, 2024
lubber-de added a commit that referenced this pull request Feb 11, 2024
Type additions for new highlightMatches and ignoreSearchCase setting as of #2963
@lubber-de lubber-de deleted the highlightMatches branch February 11, 2024 13:31
lubber-de added a commit to lubber-de/Fomantic-UI that referenced this pull request Feb 11, 2024
Type additions for new highlightMatches and ignoreSearchCase setting as of fomantic#2963
@lubber-de
Copy link
Member Author

Docs added by fomantic/Fomantic-UI-Docs#496

@lubber-de lubber-de removed the state/awaiting-docs Pull requests which need doc changes/additions label Apr 26, 2024
@lubber-de lubber-de added the state/has-docs A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo label Apr 26, 2024
lubber-de added a commit to fomantic/Fomantic-UI-Docs that referenced this pull request May 10, 2024
Examples and info about highlightMatches and ignoreSearchCase (for search) setting as of fomantic/Fomantic-UI#2963
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code state/has-docs A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo type/feat Any feature requests or improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant