-
-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dropdown,search): highlightMatches option #2963
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubber-de
added
type/feat
Any feature requests or improvements
state/awaiting-reviews
Pull requests which are waiting for reviews
javascript
Pull requests that update Javascript code
labels
Dec 14, 2023
lubber-de
added
the
state/awaiting-docs
Pull requests which need doc changes/additions
label
Dec 14, 2023
lubber-de
changed the title
feat(dropdown): highlightMatches option
feat(dropdown,search): highlightMatches option
Feb 9, 2024
lubber-de
removed
the
state/awaiting-reviews
Pull requests which are waiting for reviews
label
Feb 9, 2024
lubber-de
added a commit
that referenced
this pull request
Feb 11, 2024
Type additions for new highlightMatches and ignoreSearchCase setting as of #2963
lubber-de
added a commit
to lubber-de/Fomantic-UI
that referenced
this pull request
Feb 11, 2024
Type additions for new highlightMatches and ignoreSearchCase setting as of fomantic#2963
Docs added by fomantic/Fomantic-UI-Docs#496 |
lubber-de
removed
the
state/awaiting-docs
Pull requests which need doc changes/additions
label
Apr 26, 2024
lubber-de
added
the
state/has-docs
A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo
label
Apr 26, 2024
lubber-de
added a commit
to fomantic/Fomantic-UI-Docs
that referenced
this pull request
May 10, 2024
Examples and info about highlightMatches and ignoreSearchCase (for search) setting as of fomantic/Fomantic-UI#2963
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
javascript
Pull requests that update Javascript code
state/has-docs
A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo
type/feat
Any feature requests or improvements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new option
highlightMatches
to dropdown and search moduleCustomizing the mark (background)-color is prepared in the LESS files for a custom theme, but disabled by default. (as the default would do nothing anyway)
I decided to leave this to each browsers defaults as its visuals are most familiar to usual browser search and the
mark
HTML tag uses the exact same styling.ignoreSearchCase
available for search as we have the same for dropdown alreadyTestcase
https://jsfiddle.net/lubber/vjqe8f0d/8/
Screenshots
Closes
#2957