Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dropdown): make "set text" work for custom actions #2958

Merged
merged 3 commits into from
Dec 19, 2023

Conversation

lubber-de
Copy link
Member

@lubber-de lubber-de commented Dec 6, 2023

Description

The set text behavior was not working for custom actions whereas such function internally calls the "set text" method.
This PR also fixes showing all items before hiding when a non-multiple dropdown allowed additions

Testcase

Broken

  • open the dropdown and enter some non existing value, so the "Add..." appears
  • select that new value or press enter
  • internal call of set text does nothing (field is empty)
  • the whole dropdown menu appears for a blink of a second then hides
    https://jsfiddle.net/mikelogit/874caudh/7/

Fixed

Closes

#2955

@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug state/awaiting-reviews Pull requests which are waiting for reviews javascript Pull requests that update Javascript code labels Dec 6, 2023
@lubber-de lubber-de added this to the 2.9.4 milestone Dec 6, 2023
@lubber-de lubber-de merged commit e4ff553 into fomantic:develop Dec 19, 2023
9 checks passed
@lubber-de lubber-de deleted the dropdownCustomActionSetText branch December 19, 2023 18:28
@lubber-de lubber-de removed the state/awaiting-reviews Pull requests which are waiting for reviews label Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant