Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(form): support id only input fields for validation #2944

Merged
merged 2 commits into from
Dec 2, 2023

Conversation

lubber-de
Copy link
Member

Description

Form validation always assumes/requires a name property on each input field to work. While this is fine for "real" forms which are supposed to send data to a server, a pure div form or local validation only logic without using name (but id) properties did not work.

Not working using ids only

https://jsfiddle.net/lubber/10yhpnk4/1/

Working using ids only

https://jsfiddle.net/lubber/10yhpnk4/5/

Closes

#2939

@lubber-de lubber-de added type/feat Any feature requests or improvements state/awaiting-reviews Pull requests which are waiting for reviews javascript Pull requests that update Javascript code labels Nov 24, 2023
@lubber-de lubber-de added this to the 2.9.4 milestone Nov 24, 2023
@lubber-de lubber-de merged commit 0c7e318 into fomantic:develop Dec 2, 2023
9 checks passed
@lubber-de lubber-de deleted the supportIDOnlyField branch December 2, 2023 17:15
@lubber-de lubber-de removed the state/awaiting-reviews Pull requests which are waiting for reviews label Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code type/feat Any feature requests or improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant