Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(form): pass down element to prompt function call #2942

Merged
merged 2 commits into from
Nov 24, 2023

Conversation

alvarolm
Copy link
Contributor

@alvarolm alvarolm commented Nov 23, 2023

Description

passes down the element to the prompt function call as it might be needed to construct the prompt

non-breaking change

lubber-de
lubber-de previously approved these changes Nov 23, 2023
Copy link
Member

@lubber-de lubber-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lubber-de lubber-de added type/feat Any feature requests or improvements javascript Pull requests that update Javascript code state/awaiting-docs Pull requests which need doc changes/additions labels Nov 23, 2023
@lubber-de lubber-de added this to the 2.9.4 milestone Nov 23, 2023
remove trailing space

Co-authored-by: Marco 'Lubber' Wienkoop <[email protected]>
@lubber-de lubber-de merged commit 3c0904e into fomantic:develop Nov 24, 2023
9 checks passed
@lubber-de
Copy link
Member

@all-contributors please add @alvarolm for code

Copy link
Contributor

@lubber-de

I've put up a pull request to add @alvarolm! 🎉

@lubber-de
Copy link
Member

Docs added by fomantic/Fomantic-UI-Docs#495

@lubber-de lubber-de added state/has-docs A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo and removed state/awaiting-docs Pull requests which need doc changes/additions labels Apr 26, 2024
lubber-de added a commit to fomantic/Fomantic-UI-Docs that referenced this pull request May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code state/has-docs A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo type/feat Any feature requests or improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants