-
-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(form): pass down element to prompt function call #2942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-assign
bot
requested review from
ColinFrick,
ko2in,
lubber-de,
prudho and
y0hami
November 23, 2023 20:55
lubber-de
previously approved these changes
Nov 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
lubber-de
added
type/feat
Any feature requests or improvements
javascript
Pull requests that update Javascript code
state/awaiting-docs
Pull requests which need doc changes/additions
labels
Nov 23, 2023
lubber-de
reviewed
Nov 23, 2023
remove trailing space Co-authored-by: Marco 'Lubber' Wienkoop <[email protected]>
lubber-de
approved these changes
Nov 24, 2023
@all-contributors please add @alvarolm for code |
I've put up a pull request to add @alvarolm! 🎉 |
Docs added by fomantic/Fomantic-UI-Docs#495 |
lubber-de
added
state/has-docs
A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo
and removed
state/awaiting-docs
Pull requests which need doc changes/additions
labels
Apr 26, 2024
lubber-de
added a commit
to fomantic/Fomantic-UI-Docs
that referenced
this pull request
May 10, 2024
info about thisArg for prompt function call as of fomantic/Fomantic-UI#2942
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
javascript
Pull requests that update Javascript code
state/has-docs
A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo
type/feat
Any feature requests or improvements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
passes down the element to the prompt function call as it might be needed to construct the prompt
non-breaking change