Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(grid): fix stackable inverted grid divider for mobile screen #2924

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

ko2in
Copy link
Member

@ko2in ko2in commented Oct 10, 2023

Description

The stackable inverted grid item is not showing the divider in mobile screen due to the override by specificity of non-inverted grid.

Testcase

Before:

After:

Screenshot

Before:

inverted-grid-divider-no-border

After:

inverted-grid-divider

Closes

#2922

The stackable inverted grid item is not showing the divider in
mobile screen due to the override by specificity of non-inverted
grid.
Copy link
Member

@lubber-de lubber-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lubber-de lubber-de merged commit 7259033 into fomantic:develop Oct 10, 2023
8 checks passed
@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug lang/css Anything involving CSS labels Oct 10, 2023
@lubber-de lubber-de added this to the 2.9.4 milestone Oct 10, 2023
@ko2in ko2in deleted the fix-stackable-inverted-grid branch October 10, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/css Anything involving CSS type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants