feat(header): seamless attached variant #2909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR allows to have the attached header element with seamless variant that allows to remove the bottom border when it attaches with the another segment below.
auto-assign
bot
requested review from
ColinFrick,
lubber-de,
prudho and
y0hami
lubber-de
requested changes
Sep 22, 2023
lubber-de
added
type/feat
The attached header with seamless variant removes the bottom border which is fine for the top attached header, but the bottom attached header still need the border, so excludes to keep it's border.
lubber-de
added
state/awaiting-docs
lubber-de
approved these changes
Sep 22, 2023
lubber-de
changed the title
|
Docs added by fomantic/Fomantic-UI-Docs#478 |
lubber-de
added
state/has-docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The attached header doesn't support the seamless variant like the segment element which results in showing the border between the header and the attached element below.
This PR allows to have the attached header element with seamless variant that allows to remove the bottom border when it attaches with the another segment below.
Testcase
Before: https://jsfiddle.net/jkszwbxe/
After: https://jsfiddle.net/ko2in/yoafg8mx/1/
Screenshot
Before:
After:
Closes
#2874