fix(sidebar): dont resize on ios touchmove #2451
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubber-de
added
lang/css
lubber-de
requested review from
exoego,
ko2in,
ColinFrick,
prudho and
y0hami
|
Set on hold/switch to draft because it does not seem to fix the whole issue as mentioned in #2449 (comment) |
lubber-de
added
the
state/on-hold
lubber-de
removed
the
state/awaiting-reviews
# Conflicts: # src/definitions/modules/sidebar.js
# Conflicts: # src/definitions/modules/sidebar.less
# Conflicts: # src/themes/default/modules/sidebar.variables
# Conflicts: # src/definitions/modules/sidebar.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Safari on iOS 13.1+ seem to drag html containers on touchmove by default. At least this is happening for the sidebar.
I am not quite sure if this could break existing projects as the
pan-ydefault limits the sidebars content to only that gesture. Thinking of only default menu items, this might be ok, but other content might need other gestures(?).The
set.ios()function was already present but not used, just in case you wonder.I would appreciate if people could test this solution in their projects on real mobile devices (not just browserstack as i did), so we probably get a better idea if this is a proper solution. If not, then we are not merging this and people simply add the css selector by themselves.
Testcase
Broken
The sidebar gets shrinked
https://fomantic-ui.com/jsfiddle/#!lubber/7d2hxouf/44/
Fixed
Nothing happens as expected. Sidebar keeps its width
https://fomantic-ui.com/jsfiddle/#!lubber/7d2hxouf/43/
Closes
#2449