MODLD-593 (Spike): Retaining admin metadata after edit #56
Conversation
pkjacob
changed the title
pkjacob
force-pushed
the
pjacob/MODLD-593_2
branch
3 times, most recently
from
44ace93
to
a59c8a0
Compare
| } | ||
|
|
||
| public void copyOutgoingEdges(Resource from, Resource to) { | ||
| this.rules.entrySet() |
There was a problem hiding this comment.
Idea:
What if instead of hard-coded list of resource types/predicates we do it dynamically?
We already have a way to find a mapper by resource type / predicate / request/response dto:
org.folio.linked.data.mapper.dto.common.SingleResourceMapperImpl#getMapperUnit
So, might be we will copy every resource which doesn't have a mapper?
There was a problem hiding this comment.
Hi @PBobylev, There is one problem with this approach.
Let us assume the current graph is like this
If a cataloger open this work in editor, remove the connection to Person 1, change the creator & illustrator to Person2, and then save, the resulting graph will look like below.
Problem - We will keep the "illustrator" connection as org.folio.linked.data.mapper.dto.common.SingleResourceMapperImpl#getMapperUnit will return an empty optional for the http://bibfra.me/vocab/relation/illustrator predicate.
One (very bad) option is to add "isExcludedEdge" method as I did in this PR. I do not like it at all. Also, I think it is dangerous. We will have similar situations in future (eg: after implementing MODLD-361). If the developer forgets to update "isExcludedEdge" method with additional edges, the graph will get corrupted.
So, I prefer going back to the original approach where we control what edges has to be copied over. This way, we have better control on what edges to retain.
Thoughts?
pkjacob
force-pushed
the
pjacob/MODLD-593_2
branch
from
a59c8a0
to
287038a
Compare
pkjacob
force-pushed
the
pjacob/MODLD-593_2
branch
from
287038a
to
3ffee9e
Compare
|
|
||
| from.getOutgoingEdges() | ||
| .stream() | ||
| .filter(edge -> !isExcludedEdge(edge)) |
There was a problem hiding this comment.
I do not like this. Just added it here as a DRAFT.
No description provided.