Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MODORDERS-945, MODORDERS-953, MODORDERS-954] - Updated claiming related acq-models #434

Merged
merged 3 commits into from
Nov 7, 2023

Conversation

Abdulkhakimov
Copy link
Contributor

…ted models

Purpose

Approach

TODOS and Open Questions

Learning

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • Does this PR meet or exceed the expected quality standards?
    • Examples exist for all schemas
    • Descriptions exist for all schema properties
    • All schemas pass raml-cop linting
  • Does this introduce breaking changes?
    • Were there any schema changes?
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@Abdulkhakimov Abdulkhakimov requested a review from a team November 6, 2023 11:22
"type": "string",
"format": "date-time"
},
"claimProcessingInterval": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question

  1. Is claimProcessingInterval best name here? Maybe claimProcessingTermInDays or claimProcessingLimitInDays.
  2. What is starting point from which we count number of days?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. we already use the ending 'interval' to indicate the number of days before an action.
  2. Delay or sent interval expires: Date the piece status was changed to "Claim delayed" + claimProcessingInterval (number of days) = < current date

@Abdulkhakimov Abdulkhakimov merged commit 36af19f into master Nov 7, 2023
3 checks passed
@Abdulkhakimov Abdulkhakimov deleted the MODORDERS-945-MODORDERS-953-MODORDERS-954 branch November 7, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants