Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Improve eslint-configs #61

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: Improve eslint-configs #61

wants to merge 5 commits into from

Conversation

karannakra
Copy link
Contributor

@karannakra karannakra commented May 25, 2023 •
edited
Loading

Ticket Link 10

Pull Request 🚀

🏆 PR Goals 🏆

  • Add jsx-a11y and jsonc eslint plugins
  • Add recommended eslint configs
  • Fix all error introduced by eslint configs
  • Fix all warnings introduced by eslint configs

Changes Description 📝

After introducing suggested ESlint configuration, we relocated several of the rules intro override blocks because they weren't working.

Some ESlint rules that are no longer required have been removed.

Note ‼️

This PR Should be merged after this 👉🏻 👉🏻 #103

Getting this warning after running the lint script. looks minor

image

@vercel
Copy link

vercel bot commented May 25, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
b2b-saaskit ✅ Ready (Inspect) Visit Preview Jun 30, 2023 7:51am

@github-actions
Copy link

github-actions bot commented May 25, 2023 •
edited
Loading

Uh oh! ESLint found some issues. Please run yarn fix and commit the changes.

@karannakra
add eslint-plugin-jsonc, eslint-plugin-jsx-a11y
5956ed2
@karannakra
extends recommended-requiring-type-checking plugin for .astro,.ts,.ts…
26cc078 
…x files

move global rules which are throwing error after extending into concerned override blocks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@karannakra