-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Eslint #21
Merged
Merged
feat: Add Eslint #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
karannakra
force-pushed
the
feat--add-eslint
branch
from
May 15, 2023 21:32
a6ab1fc
to
3cdeadc
Compare
karannakra
force-pushed
the
feat--add-eslint
branch
from
May 16, 2023 23:05
3cdeadc
to
9a605a8
Compare
karannakra
force-pushed
the
feat--add-eslint
branch
from
May 17, 2023 21:04
9a605a8
to
0644237
Compare
karannakra
force-pushed
the
feat--add-eslint
branch
from
May 17, 2023 21:28
0644237
to
21b78b4
Compare
Open
Open
Check the settings of original repo, especially:
|
…-astro eslint-plugin-typescript-sort-keys eslint-plugin-markdown eslint-plugin-deprecation eslint-plugin-simple-import-sort @typescript-eslint/parser
- turn off rules that conflict with our codebase
Acknowledged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket Link Issue-10
🏆 PR Goals 🏆
--fix
flag is passed🗒️ TODO 🗒️