Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Fog::DNS::PowerDNS::Zones.all() and .get() #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

davispuh
Copy link

@davispuh davispuh commented Jul 7, 2024

I was trying

dns = Fog::DNS::PowerDNS.new({
  :host => host,
  :pdns_api_key => key
})

zones = dns.zones.all
zone = dns.zones.get('example.org')

And it was failing with

fog-powerdns-0.2.1/lib/fog/dns/powerdns/requests/get_zone.rb:37:in `get_zone': wrong number of arguments (given 1, expected 2) (ArgumentError)
fog-powerdns-0.2.1/lib/fog/dns/powerdns/models/zones.rb:21:in `get'

This is because list_zones and get_zone require a server parameter. See get_zone.rb

davispuh added 2 commits July 7, 2024 19:53
Fix `Fog::DNS::PowerDNS::Zones.all` and `.get`
`list_zones` and `get_zone` requires a server parameter
@davispuh
Copy link
Author

Ping? Could someone take a look at my PRs. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant