-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding encrypted data bags support #45
base: master
Are you sure you want to change the base?
Conversation
+1 on this, I've been using this branch for several months because I like to store developer ssh keys in my user data bags. |
@fnichol What do you think? +1 |
👍 |
4 similar comments
+1 |
+1 |
+1 |
+1 |
@maksar thanks for the PR and very sorry for getting back so late. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is a lot of value in getting this merged-in to the LWRP. I agree with Ranjib's feedback and would like to see the data_bag_encrption_key attribute removed.
I know this has been outstanding for awhile, so if you aren't able to make these changes please let us know.
name = i.gsub(/[.]/, '-') | ||
|
||
u = if node['user']['data_bag_encrypted'] | ||
Chef::EncryptedDataBagItem.load(bag, name, node['user']['data_bag_encryption_key']) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should rely on the key being provided in the client's config and not here. We should remove any references to this attribute:
Chef::EncryptedDataBagItem.lad(bag, name)
By using
"data_bag_encrypted" : true
it is now possible to use encrypted data bags.