Don't raise ActiveRecord::RecordNotFound for missing attachments.

fnando · Oct 10, 2015 · f16cd8e · f16cd8e
1 parent 89b870f
commit f16cd8e
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/lib/coupons/globalid_serializer.rb b/lib/coupons/globalid_serializer.rb
@@ -5,7 +5,9 @@ def self.load(attachments)
       attachments = JSON.load(attachments)
 
       attachments.each_with_object({}) do |(key, uri), buffer|
-        buffer[key.to_sym] = GlobalID::Locator.locate(uri)
+        buffer[key.to_sym] = GlobalID::Locator
+                              .locate_many([uri], ignore_missing: true)
+                              .first
       end
     end
 

diff --git a/spec/models/coupons/models/coupon_spec.rb b/spec/models/coupons/models/coupon_spec.rb
@@ -165,5 +165,18 @@
 
       expect(coupon.reload.attachments[:category]).to eq(category)
     end
+
+    it 'returns missing attachments as nil' do
+      coupon = create_coupon(
+        amount: 10,
+        type: 'amount',
+        attachments: {category: category}
+      )
+
+      category.destroy
+      coupon.reload
+
+      expect(coupon.attachments[:category]).to be_nil
+    end
   end
 end