New probability of precipitation algorithm #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tackandr
reviewed
Aug 13, 2021
| { | ||
| out_area = 1.; | ||
| } | ||
| maxprob = 0.9; | ||
| } |
There was a problem hiding this comment.
Nicely de-convoluted version of the makro template. Much more easy to read.
| { | ||
| out_result = 1 + rand() % 5; | ||
| } | ||
| r = min(r, maxprob); | ||
| } |
There was a problem hiding this comment.
Implementation of the algorithm looks correct to me.
| // >131h ennusteet: Prob EC(6h) RR>=0.15mm | ||
| // lisäksi huomioidaan että jos editoitu sadetta, myös POP arvoja | ||
| // lisäksi kaukaisia sateita heikennetään | ||
| // lopuksi tehdään aluetasoitus |
There was a problem hiding this comment.
Could you take a moment to translate this to English? Just would be more consistent to have one language only.
There was a problem hiding this comment.
Sure thing. I was lazy and simply copy-pasted from the macro.
|
This was merged to development branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.fmi.fi/browse/STU-16065