Rail weather script with LUA #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpartio
approved these changes
May 25, 2021
| return pmin | ||
| end | ||
|
|
||
| function MaxT(TMinus,TPlus,curTime,par,curLevel) |
There was a problem hiding this comment.
What does the "T" in the function name signal?
There was a problem hiding this comment.
Time I assume. That's how they are named in smartmet macro.
|
|
||
| result:SetParam(param("RAIL-N")) | ||
| result:SetValues(res) | ||
| luatool:WriteToFile(result) |
There was a problem hiding this comment.
Have you tried running this when min_t is missing? What happens if empty "res" is written to a file? (Don't want to crash Himan because of it)
| end | ||
|
|
||
| -- adjust time | ||
| mytime:GetValidDateTime():Adjust(HPTimeResolution.kHourResolution, -1) |
There was a problem hiding this comment.
This is ok but it will waste a lot of effort when we know that 144h onwards data is present only every 6hrs. Means more log spam of "data not found" :)
There was a problem hiding this comment.
This needs to be run in combination with transformer time interpolation to mimic the behavior of the smartmet functions.
vkuvaja
reviewed
May 25, 2021
vkuvaja
approved these changes
May 25, 2021
vkuvaja
approved these changes
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is implementation for regulation 5 railroad weather
macro
Jira ticket is
here