HIMAN-329: Short circuit coordinate transformation logic #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Himan transforms coordinates between projections (with gdal) using latlon as an intermediate representation. This introduces some very small numerical inaccuracies, which eventually push some valid grid points outside the grid in some circumstances. Introduce a "bulk" transformation method where coordinate transformation is done directly from source to target utilizing gdal methods. Implemented only for regular grids.
tackandr
reviewed
Mar 11, 2021
Comment on lines
+220
to
+224
|
|
||
| /* Return grid point value (location) of a given target grid */ | ||
| virtual std::vector<point> XY(const regular_grid& to) const; | ||
|
|
||
| /* Return latitude-longitude value for a given location index */ |
There was a problem hiding this comment.
I personally wouldn't define a bunch of new functions for the bulk calculations but use the single point functions as unary operators in std:transform algorithm library function.
There was a problem hiding this comment.
The bulk function is using a slightly different method to transform coordinates, hence it cannot be done the way you describe.
|
Is this the place to make general comments on the commit? |
I don't know but why not :D |
Just trying out the interface |
vkuvaja
reviewed
Mar 18, 2021
himan-lib/source/grid.cpp
Outdated
| @@ -80,6 +80,10 @@ void grid::UVRelativeToGrid(bool theUVRelativeToGrid) | |||
| { | |||
| itsUVRelativeToGrid = theUVRelativeToGrid; | |||
| } | |||
| std::vector<point> grid::GridPointsInProjectionSpace() const | |||
| { | |||
| throw runtime_error("grid::GridPointInProjectionSpace() called"); | |||
There was a problem hiding this comment.
GridPointIn.. -> GridPointsIn..
vkuvaja
approved these changes
Mar 19, 2021
tackandr
approved these changes
Mar 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Himan transforms coordinates between projections (with gdal) using latlon
as an intermediate representation. This introduces some very small numerical
inaccuracies, which eventually push some valid grid points outside the grid
in some circumstances.
Introduce a "bulk" transformation method where coordinate transformation is
done directly from source to target utilizing gdal methods. Implemented only
for regular grids.