Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-TCU update #18

Merged
merged 2 commits into from
Sep 9, 2024
Merged

CB-TCU update #18

merged 2 commits into from
Sep 9, 2024

Conversation

tackandr
Copy link
Contributor

@tackandr tackandr commented Sep 5, 2024

Changes that were requested to CB-TCU calculation. Just applying to MEPS for now. Basically some filters were applied to the input data.
https://jira.fmi.fi/browse/STU-24741

@tackandr tackandr requested a review from mpartio September 5, 2024 12:03
EL500 = Max2D(Nmat,filter,configuration:GetUseCuda()):GetValues()

Nmat:SetValues(pEL500)
pEL500 = Min2D(Nmat,filter,configuration:GetUseCuda()):GetValues()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why take smallest pressure (highest level measured from ground up) instead of say average?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The macro is using the Max2D EL500 height above ground in the filter area. So then for the EL500 pressure I use Min2D as pressure decreases with altitude. Instead of taking the Max2D of EL500 and converting the height to pressure.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you mean why the macro is using the Max instead of Avg I assume it is done so that airplanes stay above convection at any time. You know the tale of the horse that drowned in a river that was on average 1m deep.

@mpartio
Copy link
Member

mpartio commented Sep 9, 2024

Looks clear to me (added one question though), and from what I see it also matches the macro 👍

@mpartio mpartio merged commit d8ef95c into master Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants