remove earth shape hard coding for MEPS domains #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpartio
reviewed
Sep 27, 2023
| @@ -705,6 +671,10 @@ void WriteAreaAndGrid(NFmiGribMessage& message, const shared_ptr<himan::grid>& g | |||
| { | |||
| message.SetLongKey("shapeOfTheEarth", 0); | |||
| } | |||
| else if (earth.A() == 6371229) | |||
There was a problem hiding this comment.
Maybe also check that A() == B() so we know it's a sphere.
There was a problem hiding this comment.
It's actually checked couple of lines above but not part of the diff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When earth shape in Radon is changed for MEPS then hard coded WGS84 fixes in himan need to be removed for everything to work properly. Please have a look but don't merge yet. Please have a look to make sure I didn't miss something. Then we can continue to run himan-tests with this fixed version.