Update of boundary layer turbulence algorithm #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpartio
reviewed
Aug 2, 2021
himan-scripts/bl-turbulence.lua
Outdated
Comment on lines
42
to
43
| if currentProducerName == "ECGMTA" then | ||
| gustlevel = level(HPLevelType.kGround, 0) |
There was a problem hiding this comment.
Just did this:
radon=> insert into param_level_transform values (default, 131, (select id from param where name = 'FFG-MS'), 1, 0, 6, 10);
INSERT 0 1
So Himan automatically knows to fetch FFG-MS from ground/0 if it's requested for height/10.
mpartio
reviewed
Aug 2, 2021
himan-scripts/bl-turbulence.lua
Outdated
| local surface = {} | ||
| if currentProducerName == "ECGMTA" then | ||
| surface = level(HPLevelType.kGround, 0) | ||
| landseamask = param("N-0TO1") |
mpartio
reviewed
Aug 2, 2021
himan-scripts/bl-turbulence.lua
Outdated
| turb = 4 | ||
| end | ||
| if wskt>22 and maxTKE>3.5 then | ||
| if wskt>22 and (wgust>18 or maxshear>20) then |
There was a problem hiding this comment.
wgust-conditional should be:
wgust>16
mpartio
reviewed
Aug 2, 2021
|
|
||
| local maxshear = math.max(shear, shear12, shear23, shear34) |
There was a problem hiding this comment.
Nice way to reduce the verbose if-statements in the original macro 👍
mpartio
reviewed
Aug 2, 2021
| @@ -48,116 +72,145 @@ logger:Info("Calculating wind shear") | |||
| -- because only change in wind direction and speed is needed, not absolutely correct direction | |||
|
|
|||
| local dz = 304.8 | |||
| -- 2) Use lowest model level wind for sfc shear in ***Hirlam: | |||
| -- Wind component differences between Hirlam lowest model level (L65 ~12m) and 1000ft (above it) | |||
| local U_HIR = param("U-MS") | |||
There was a problem hiding this comment.
Why are these two variables called "HIR" ?
mpartio
reviewed
Aug 13, 2021
| @@ -1344,6 +1344,7 @@ void BindLib(lua_State* L) | |||
| .def("Empty", &raw_time::Empty), | |||
| class_<forecast_time>("forecast_time") | |||
| .def(constructor<const raw_time&, const raw_time&>()) | |||
| .def(constructor<const raw_time&, const time_duration&>()) | |||
mpartio
reviewed
Aug 13, 2021
| -- SEV over sea | ||
| if wskt>40 and wgust>23 then | ||
| turb = 5 | ||
| end |
There was a problem hiding this comment.
Overall looks good to me and I can't find any problems, good work.
mpartio
approved these changes
Aug 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.fmi.fi/browse/STU-16161