Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only rebuild year info when year has actually changed #124

Closed
wants to merge 1 commit into from
Closed

fix: only rebuild year info when year has actually changed #124

wants to merge 1 commit into from

Conversation

oll3
Copy link
Contributor

@oll3 oll3 commented Jul 13, 2024

Not sure but thought the comparison below looked potentially wrong, where it checks in the month_info year has changed... Shouldn't it check the year_info year instead to decide if it's time to rebuild the year info?

!matches!(&self.month_info, Some(month_info) if month_info.last_year == year)

PR also moves the rebuild of year out from rebuild_inner() since it's only done inside rebuild().

@oll3 oll3 closed this Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant