Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added invitation views settings #15

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Added invitation views settings #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
aca54a1
Added views setting variables
artemdumanov May 16, 2020
709de8e
Fixed urls to consume views from settings
artemdumanov May 16, 2020
7cdfd20
Moved views callable import to the urls
artemdumanov May 16, 2020
532c228
Removed callable views import from app_settings
artemdumanov May 16, 2020
36d1887
Fixed import
artemdumanov May 16, 2020
c673fda
Added callable import
artemdumanov May 16, 2020
9045162
Update urls.py
artemdumanov May 16, 2020
040c898
Update urls.py
artemdumanov May 16, 2020
6cb0639
Update utils.py
artemdumanov Dec 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion rest_invitations/urls.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,24 @@
from rest_framework import routers

from .app_settings import ACCEPT_INVITE_URL, API_BASE_URL
from .views import InvitationViewSet, accept_invitation
from .views import (InvitationViewSet, accept_invitation)
from .utils import import_callable
from django.conf import settings

InvitationViewSet = import_callable(
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add some doc info about these changes?

getattr(
settings,
'INVITATION_VIEW',
InvitationViewSet
)
)
accept_invitation = import_callable(
getattr(
settings,
'INVITATION_ACCEPT_INVATION',
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems a typo

accept_invitation
)
)

router = routers.SimpleRouter()
router.register(r'{0}'.format(API_BASE_URL), InvitationViewSet)
Expand Down
1 change: 0 additions & 1 deletion rest_invitations/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,4 @@ def import_callable(path):
return path
else:
module, attr_name = path.rsplit('.', 1)
print(module, attr_name)
return getattr(import_module(module), attr_name)