Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Go 1.16 -> Go 1.18 #266

Merged
merged 9 commits into from
Jun 3, 2022
Merged

Go 1.16 -> Go 1.18 #266

merged 9 commits into from
Jun 3, 2022

Conversation

mayitbeegh
Copy link
Contributor

@mayitbeegh mayitbeegh commented Jun 1, 2022

TL;DR

Starting from v1.46.0, golangci-lint no longer works with Go 1.16. This causes PR checks to fail, example https://github.com/flyteorg/flyteplugins/runs/6632158946?check_suite_focus=true
This PR fixes the PR checks by upgrading from Go 1.16 to Go 1.18.
End-to-end tested in flytepropeller and flyteadmin

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue

Follow-up issue

NA

Signed-off-by: Sean Lin <[email protected]>
@codecov
Copy link

codecov bot commented Jun 1, 2022

Codecov Report

Merging #266 (5a08e30) into master (82be16b) will decrease coverage by 0.00%.
The diff coverage is 60.00%.

❗ Current head 5a08e30 differs from pull request most recent head b46a28e. Consider uploading reports for the commit b46a28e to get more accurate results

@@            Coverage Diff             @@
##           master     #266      +/-   ##
==========================================
- Coverage   62.55%   62.55%   -0.01%     
==========================================
  Files         142      142              
  Lines        8961     8960       -1     
==========================================
- Hits         5606     5605       -1     
  Misses       2834     2834              
  Partials      521      521              
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
go/tasks/plugins/array/k8s/subtask_exec_context.go 81.72% <60.00%> (-0.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82be16b...b46a28e. Read the comment docs.

@eapolinario eapolinario mentioned this pull request Jun 2, 2022
8 tasks
@mayitbeegh mayitbeegh changed the title wip Fix make test Go 1.16 -> Go 1.18 Jun 3, 2022
@mayitbeegh mayitbeegh marked this pull request as ready for review June 3, 2022 00:11
Signed-off-by: Sean Lin <[email protected]>
@mayitbeegh mayitbeegh merged commit 2c83e24 into master Jun 3, 2022
@mayitbeegh mayitbeegh deleted the fix-download-tooling-err branch June 3, 2022 03:01
eapolinario pushed a commit that referenced this pull request Sep 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants