Fix unit tests in airflow plugin #3024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Su <[email protected]>
pingsutw
requested review from
wild-endeavor,
kumare3,
eapolinario,
cosmicBboy,
samhita-alla,
thomasjpfan and
Future-Outlier
as code owners
Code Review Agent Run #21fa33Actionable Suggestions - 1
Review Details
AI Code Review powered by |
flyte-bot
reviewed
Dec 28, 2024
plugins/flytekit-airflow/setup.py
Outdated
| @@ -6,6 +6,7 @@ | |||
|
|
|||
| plugin_requires = [ | |||
| "apache-airflow", | |||
| "apache-airflow-providers-google<12.0.0" | |||
There was a problem hiding this comment.
Missing comma in dependency list
Consider adding a comma after apache-airflow-providers-google<12.0.0 to maintain proper syntax in the plugin_requires list.
Code suggestion
Check the AI-generated fix before applying
Suggested change
| "apache-airflow-providers-google<12.0.0" | |
| "apache-airflow-providers-google<12.0.0", |
Code Review Run #21fa33
Is this a valid issue, or was it incorrectly flagged by the Agent?
- it was incorrectly flagged
Signed-off-by: Kevin Su <[email protected]>
Code Review Agent Run #fe9592Actionable Suggestions - 0Review Details
AI Code Review powered by |
wild-endeavor
approved these changes
Dec 30, 2024
kumare3
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
NA
Why are the changes needed?
apache-airflow-providers-googlehas a new release 12.0.0,apache-airflowis not compatible with itWhat changes were proposed in this pull request?
set uppoer-bound in the setup.py
How was this patch tested?
unit tests
Setup process
Screenshots
Check all the applicable boxes
Summary by Bito
Added version constraint in setup.py to resolve compatibility issues between apache-airflow and apache-airflow-providers-google package. The change prevents usage of apache-airflow-providers-google versions 12.0.0 and above to maintain system stability and prevent potential runtime issues due to incompatible package versions.Unit tests added: False
Estimated effort to review (1-5, lower is better): 1