This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
Cache Serialize API #215
Merged
Cache Serialize API #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for opening this pull request! 🙌
|
hamersaw
changed the title
8 tasks
hamersaw
changed the title
hamersaw
changed the title
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
… - only reservations. Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
…ame change Signed-off-by: Daniel Rammer <[email protected]>
hamersaw
force-pushed
the
refactor/artifact-reservation-api
branch
from
166791c to
100abab
Compare
EngHabu
previously approved these changes
Nov 13, 2021
Signed-off-by: Daniel Rammer <[email protected]>
EngHabu
previously approved these changes
Nov 18, 2021
kumare3
reviewed
Nov 19, 2021
protos/flyteidl/core/tasks.proto
Outdated
| @@ -92,6 +92,9 @@ message TaskMetadata { | |||
| oneof interruptible_value { | |||
| bool interruptible = 8; | |||
| }; | |||
|
|
|||
| // Indicates whether the system should attempt to execute discoverable instances in serial to avoid duplicate work | |||
| bool discovery_serializable = 9; | |||
There was a problem hiding this comment.
i hate this name. I guess we want to keep it so.
but, ideally it should be cache_serializable right?
There was a problem hiding this comment.
done. i'm ok with the switch, it hurt me to try and keep it uniform.
Signed-off-by: Daniel Rammer <[email protected]>
EngHabu
approved these changes
Nov 23, 2021
kumare3
approved these changes
Nov 23, 2021
eapolinario
pushed a commit
that referenced
this pull request
Sep 8, 2023
* removed datacatalog ExtendReservation API Signed-off-by: Daniel Rammer <[email protected]> * filled out generated content with 'make generate' Signed-off-by: Daniel Rammer <[email protected]> * updated protobuf docs for admin and core definitions Signed-off-by: Daniel Rammer <[email protected]> * created ReservationID message to reuse Signed-off-by: Daniel Rammer <[email protected]> * changed artifact reservation API to not include handling of artifacts - only reservations. Signed-off-by: Daniel Rammer <[email protected]> * added cache reservation comments Signed-off-by: Daniel Rammer <[email protected]> * fixed indenting issues that always drive me crazy Signed-off-by: Daniel Rammer <[email protected]> * updated discovery_reservable to discovery_serializable to adhere to name change Signed-off-by: Daniel Rammer <[email protected]> * moved catalog reservation status enum into a message Signed-off-by: Daniel Rammer <[email protected]> * changed discovery_serializable TaskMetadata field to cache_serializable Signed-off-by: Daniel Rammer <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Removes the ExtendReservation API from the datacatalog protobuf definition.
Type
Are all requirements met?
Complete description
The datacatalog ExtendReservation API is continually called when an Artifact is already reserved and that reservation needs to be extended past the current expiration. We are changing the implementation of the GetOrReserveArtifact API to extend a reservation if valid. Therefore, ExtendReservation is no longer necessary. We have included additional fields into the GetOrReserveArtifactResponse to reflect these changes.
Tracking Issue
flyteorg/flyte#267
flyteorg/flyte#872
Follow-up issue
NA