Skip to content
This repository has been archived by the owner on May 31, 2024. It is now read-only.

Update old docs links #465

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Update old docs links #465

merged 1 commit into from
Mar 4, 2024

Conversation

neverett
Copy link
Contributor

TL;DR

This PR updates outdated docs links, since those links will break once we switch this repo (and others) to the new monodocs build process.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

Signed-off-by: nikki everett <[email protected]>
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.65%. Comparing base (6488cc8) to head (b1d822a).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #465   +/-   ##
=======================================
  Coverage   67.65%   67.65%           
=======================================
  Files         148      148           
  Lines        6643     6643           
=======================================
  Hits         4494     4494           
  Misses       1859     1859           
  Partials      290      290           
Flag Coverage Δ
unittests 67.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pingsutw pingsutw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! @neverett could you also help update the old doc links in flytekit?
https://github.com/flyteorg/flytekit/blob/master/README.md

@neverett neverett merged commit 559a47a into master Mar 4, 2024
15 checks passed
@neverett neverett deleted the docs/update-links branch March 4, 2024 15:21
@neverett
Copy link
Contributor Author

neverett commented Mar 4, 2024

@pingsutw yep, there's a PR for that already: flyteorg/flytekit#2210

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants