Skip to content
This repository has been archived by the owner on May 31, 2024. It is now read-only.

Fix: Check for git authentication when GITHUB_TOKEN exists #463

Merged
merged 3 commits into from
Feb 20, 2024

Conversation

jsong336
Copy link
Contributor

@jsong336 jsong336 commented Feb 17, 2024

TL;DR

When flytectl demo start is ran with GITHUB_TOKEN, it throws 401 error. Setting GITHUB_TOKEN empty works.
flyteorg/flyte#4879

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

  • Validating GITHUB client before creating gh

Tracking Issue

https://github.com/flyteorg/flyte/issues/

Follow-up issue

@jsong336 jsong336 marked this pull request as draft February 17, 2024 20:25
Signed-off-by: Jeongwon Song <[email protected]>
Signed-off-by: Jeongwon Song <[email protected]>
Signed-off-by: Jeongwon Song <[email protected]>
Copy link
Member

@pingsutw pingsutw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

Copy link

codecov bot commented Feb 18, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (9c87165) 67.69% compared to head (af6308b) 67.65%.

Files Patch % Lines
pkg/github/githubutil.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #463      +/-   ##
==========================================
- Coverage   67.69%   67.65%   -0.05%     
==========================================
  Files         148      148              
  Lines        6639     6643       +4     
==========================================
  Hits         4494     4494              
- Misses       1855     1859       +4     
  Partials      290      290              
Flag Coverage Δ
unittests 67.65% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsong336
Copy link
Contributor Author

jsong336 commented Feb 18, 2024

@pingsutw hmmm not sure what's best way to write test for this, are we able bypass test for this PR?

@pingsutw pingsutw merged commit 6488cc8 into flyteorg:master Feb 20, 2024
13 of 15 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants