Skip to content
This repository has been archived by the owner on May 31, 2024. It is now read-only.

OverwriteCache flag for creating/relaunching executions #358

Merged
merged 5 commits into from
Nov 16, 2022

Conversation

MorpheusXAUT
Copy link
Contributor

@MorpheusXAUT MorpheusXAUT commented Oct 5, 2022

TL;DR

Added CLI flag to overwrite cache while creating or relaunching an execution.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Added --overwriteCache boolean flag to the create executions command, supports skipping cache when creating or relaunching executions.

As this uses currently unmerged versions of flyteidl and flytestdlib, the PR is created as a draft (for review) until the respective new versions are available.

Tracking Issue

flyteorg/flyte#2867

Follow-up issue

NA

@codecov
Copy link

codecov bot commented Oct 7, 2022

Codecov Report

Merging #358 (5108851) into master (209fe93) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #358      +/-   ##
==========================================
+ Coverage   68.63%   68.65%   +0.01%     
==========================================
  Files         143      143              
  Lines        4980     4983       +3     
==========================================
+ Hits         3418     3421       +3     
  Misses       1312     1312              
  Partials      250      250              
Flag Coverage Δ
unittests 68.32% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/create/execution.go 93.93% <ø> (ø)
cmd/create/execution_util.go 95.00% <100.00%> (+0.06%) ⬆️
cmd/create/executionconfig_flags.go 45.71% <100.00%> (+1.59%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@hamersaw hamersaw changed the title SkipCache flag for creating/relaunching executions #minor SkipCache flag for creating/relaunching executions Nov 7, 2022
@MorpheusXAUT MorpheusXAUT changed the title SkipCache flag for creating/relaunching executions OverwriteCache flag for creating/relaunching executions Nov 15, 2022
@MorpheusXAUT MorpheusXAUT marked this pull request as ready for review November 15, 2022 08:39
wild-endeavor
wild-endeavor previously approved these changes Nov 15, 2022
Nick Müller added 5 commits November 16, 2022 11:00
@hamersaw hamersaw merged commit cea39d9 into flyteorg:master Nov 16, 2022
@MorpheusXAUT MorpheusXAUT deleted the execution-skip-cache branch November 16, 2022 19:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants