This repository has been archived by the owner on May 31, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 83
OverwriteCache flag for creating/relaunching executions #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MorpheusXAUT
force-pushed
the
execution-skip-cache
branch
from
October 7, 2022 09:18
9172549
to
bae2431
Compare
Codecov Report
@@ Coverage Diff @@
## master #358 +/- ##
==========================================
+ Coverage 68.63% 68.65% +0.01%
==========================================
Files 143 143
Lines 4980 4983 +3
==========================================
+ Hits 3418 3421 +3
Misses 1312 1312
Partials 250 250
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
hamersaw
changed the title
SkipCache flag for creating/relaunching executions #minor
SkipCache flag for creating/relaunching executions
Nov 7, 2022
MorpheusXAUT
changed the title
SkipCache flag for creating/relaunching executions
OverwriteCache flag for creating/relaunching executions
Nov 15, 2022
MorpheusXAUT
requested review from
kumare3,
EngHabu and
wild-endeavor
as code owners
November 15, 2022 08:39
wild-endeavor
previously approved these changes
Nov 15, 2022
hamersaw
reviewed
Nov 15, 2022
Signed-off-by: Nick Müller <[email protected]>
Signed-off-by: Nick Müller <[email protected]>
Updated to latest released version of flyteidl Signed-off-by: Nick Müller <[email protected]>
Signed-off-by: Nick Müller <[email protected]>
…nConfig Signed-off-by: Nick Müller <[email protected]>
MorpheusXAUT
force-pushed
the
execution-skip-cache
branch
from
November 16, 2022 10:25
96037c7
to
5108851
Compare
hamersaw
approved these changes
Nov 16, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Added CLI flag to overwrite cache while creating or relaunching an execution.
Type
Are all requirements met?
Complete description
Added
--overwriteCache
boolean flag to thecreate executions
command, supports skipping cache when creating or relaunching executions.As this uses currently unmerged versions offlyteidl
andflytestdlib
, the PR is created as a draft (for review) until the respective new versions are available.Tracking Issue
flyteorg/flyte#2867
Follow-up issue
NA