Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Show execution create time in execution detail page #841

Closed
wants to merge 1 commit into from
Closed

feat: Show execution create time in execution detail page #841

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions packages/console/src/components/Executions/ExecutionDetails/ExecutionMetadata.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
const { execution } = React.useContext(ExecutionContext);

const { domain } = execution.id;
const { abortMetadata, duration, error, startedAt, workflowId } =
const { abortMetadata, duration, error, startedAt, createdAt, workflowId } =
execution.closure;
const { referenceExecution, systemMetadata } = execution.spec.metadata;
const cluster = systemMetadata?.executionCluster ?? dashedValueString;
Expand All @@ -80,11 +80,17 @@
value: cluster,
},
{
label: ExecutionMetadataLabels.time,
label: ExecutionMetadataLabels.startedAt,
value: startedAt
? formatDateUTC(timestampToDate(startedAt))
: dashedValueString,
},
{
label: ExecutionMetadataLabels.createdAt,
value: createdAt
? formatDateUTC(timestampToDate(createdAt))
: dashedValueString,

Check warning on line 92 in packages/console/src/components/Executions/ExecutionDetails/ExecutionMetadata.tsx

View check run for this annotation

Codecov / codecov/patch

packages/console/src/components/Executions/ExecutionDetails/ExecutionMetadata.tsx#L92 

Added line #L92 was not covered by tests
},
{
label: ExecutionMetadataLabels.duration,
value: duration ? protobufDurationToHMS(duration) : dashedValueString,
Expand Down
3 changes: 2 additions & 1 deletion packages/console/src/components/Executions/ExecutionDetails/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@ export enum ExecutionMetadataLabels {
cluster = 'Cluster',
domain = 'Domain',
duration = 'Duration',
time = 'Time',
startedAt = 'Start time',
createdAt = 'Create time',
relatedTo = 'Related to',
version = 'Version',
serviceAccount = 'Service Account',
Expand Down
2 changes: 1 addition & 1 deletion packages/console/src/components/Executions/ExecutionDetails/test/ExecutionMetadata.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { ExecutionMetadataLabels } from '../constants';
import { ExecutionMetadata } from '../ExecutionMetadata';

const clusterTestId = `metadata-${ExecutionMetadataLabels.cluster}`;
const startTimeTestId = `metadata-${ExecutionMetadataLabels.time}`;
const startTimeTestId = `metadata-${ExecutionMetadataLabels.startedAt}`;
const durationTestId = `metadata-${ExecutionMetadataLabels.duration}`;
const interruptibleTestId = `metadata-${ExecutionMetadataLabels.interruptible}`;
const overwriteCacheTestId = `metadata-${ExecutionMetadataLabels.overwriteCache}`;
Expand Down
Loading