updates from PR review

Signed-off-by: Blake Jackson <[email protected]>
flyteorg · Jul 9, 2024 · 6246b2a · 6246b2a
1 parent 41e0139
commit 6246b2a
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/packages/oss-console/src/components/Executions/ExecutionDetails/ExecutionLabels.tsx b/packages/oss-console/src/components/Executions/ExecutionDetails/ExecutionLabels.tsx
@@ -15,7 +15,7 @@ const useStyles = makeStyles({
     maxWidth: '420px'
   },
   chip: {
-    margin: 4,
+    margin: '2px 2px 2px 0',
   },
 });
 
@@ -26,6 +26,7 @@ export const ExecutionLabels: React.FC<Props> = ({values}) => {
     <div className={classes.chipContainer}>
       {Object.entries(values).map(([key, value]) => (
         <Chip
+          color='info'
           key={key}
           label={value ? `${key}: ${value}` : key}
           className={classes.chip}

diff --git a/packages/oss-console/src/components/Executions/ExecutionDetails/ExecutionMetadata.tsx b/packages/oss-console/src/components/Executions/ExecutionDetails/ExecutionMetadata.tsx
@@ -131,7 +131,8 @@ export const ExecutionMetadata: React.FC<{}> = () => {
     details.push({
       label: ExecutionMetadataLabels.labels,
       value: (
-        <ExecutionLabels values={labels.values} />
+        Object.entries(labels.values).length > 0 ? 
+          <ExecutionLabels values={labels.values} /> : dashedValueString
       )
     })
   }

diff --git a/...es/oss-console/src/components/Executions/ExecutionDetails/test/ExecutionMetadata.test.tsx b/...es/oss-console/src/components/Executions/ExecutionDetails/test/ExecutionMetadata.test.tsx
@@ -119,7 +119,7 @@ describe('ExecutionMetadata', () => {
     const { getByTestId } = renderMetadata();
     expect(getByTestId(parentNodeExecutionTestId)).toHaveTextContent('name');
   })
-  
+
   it('shows labels if spec has them', () => {
     const { getByTestId } = renderMetadata();
     expect(getByTestId(labelsTestId)).toHaveTextContent("key: value");