Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Refactored type casting into flyteidl #548

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hamersaw
Copy link
Contributor

TL;DR

To allow re-use of literal casting in other repositories this PR refactors the code into flyteidl.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

^^^

Tracking Issue

NA

Follow-up issue

NA

Signed-off-by: Daniel Rammer <[email protected]>
@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Merging #548 (f1dbe0a) into master (eb695b1) will increase coverage by 1.47%.
The diff coverage is 100.00%.

❗ Current head f1dbe0a differs from pull request most recent head 4c343ec. Consider uploading reports for the commit 4c343ec to get more accurate results

@@            Coverage Diff             @@
##           master     #548      +/-   ##
==========================================
+ Coverage   58.85%   60.32%   +1.47%     
==========================================
  Files         170      170              
  Lines       16068    13155    -2913     
==========================================
- Hits         9457     7936    -1521     
+ Misses       5777     4385    -1392     
  Partials      834      834              
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/manager/impl/validation/execution_validator.go 73.80% <100.00%> (+1.73%) ⬆️
...g/manager/impl/validation/launch_plan_validator.go 63.54% <100.00%> (+1.55%) ⬆️
pkg/manager/impl/validation/signal_validator.go 81.81% <100.00%> (+2.50%) ⬆️
pkg/manager/impl/validation/validation.go 95.62% <100.00%> (+0.95%) ⬆️

... and 152 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant