Add new sandbox-bundled-offloaded-functional-tests for offloading literals unit test
#6111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mecoli1219 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6111 +/- ##
=======================================
Coverage 37.00% 37.01%
=======================================
Files 1318 1318
Lines 132519 132519
=======================================
+ Hits 49040 49046 +6
+ Misses 79235 79229 -6
Partials 4244 4244
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Mecoli1219 <[email protected]>
Signed-off-by: Mecoli1219 <[email protected]>
Signed-off-by: Mecoli1219 <[email protected]>
Signed-off-by: Mecoli1219 <[email protected]>
Mecoli1219
changed the title
sandbox-bundled-offloaded-functional-tests for offloading literals unit testsandbox-bundled-offloaded-functional-tests for offloading literals unit test
Signed-off-by: Mecoli1219 <[email protected]>
Mecoli1219
changed the title
sandbox-bundled-offloaded-functional-tests for offloading literals unit testsandbox-bundled-offloaded-functional-tests for offloading literals unit test
|
@pmahindrakar-oss this PR is ready to be reviewed |
pingsutw
previously approved these changes
Dec 27, 2024
Signed-off-by: Eduardo Apolinario <[email protected]>
eapolinario
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Currently, there seems to be no CI test covering the end-to-end offloaded test at the
flyterepo. This PR create one.What changes were proposed in this pull request?
Copy the
sandbox-bundled-functional-test, and add new propeller parameters in the flyteconfig.yamlfile. By setting themin-size-in-mb-for-offloadingto be0.000001(aka. 1e-6MB = 1B), almost all the output of the task should be offloaded.How was this patch tested?
I first run a local cluster with the updated config file, and test the flytesnacks advanced_composition examples to make sure it will actually offload the literal.
For the real CI test, I'll have to rely on the CI for this PR.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link