Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variables to ease separate bucket config #5015

Merged

Conversation

davidmirror-ops
Copy link
Contributor

Tracking issue

Closes #4291

Why are the changes needed?

Closing #4759 in favor of this simpler implementation achieving the same goal.

What changes were proposed in this pull request?

How was this patch tested?

Deployed on a live EKS cluster,a wf execution correctly stored closure on metadata bucket and offloaded outputs to user bucket.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. enhancement New feature or request labels Mar 6, 2024
Signed-off-by: davidmirror-ops <david [email protected]>
@davidmirror-ops davidmirror-ops force-pushed the 4291-separate-buckets branch from 03badc2 to 6e415a0 Compare March 6, 2024 17:45
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.10%. Comparing base (ba86c69) to head (87dbc18).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5015      +/-   ##
==========================================
- Coverage   59.11%   59.10%   -0.02%     
==========================================
  Files         645      645              
  Lines       55574    55574              
==========================================
- Hits        32852    32846       -6     
- Misses      20129    20135       +6     
  Partials     2593     2593              
Flag Coverage Δ
unittests 59.10% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: davidmirror-ops <david [email protected]>
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Mar 6, 2024
@davidmirror-ops davidmirror-ops requested a review from pingsutw March 6, 2024 18:08
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Mar 11, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Mar 13, 2024
Signed-off-by: davidmirror-ops <david [email protected]>
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Mar 13, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Mar 21, 2024
Signed-off-by: davidmirror-ops <david [email protected]>
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Mar 21, 2024
davidmirror-ops and others added 3 commits March 27, 2024 07:00
@dosubot dosubot bot removed the size:L This PR changes 100-499 lines, ignoring generated files. label Apr 1, 2024
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Apr 1, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 1, 2024
@davidmirror-ops davidmirror-ops merged commit 524b473 into flyteorg:master Apr 1, 2024
51 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Core feature] Allow to specify userdata bucket in the storage configuration in flyte-core charts
2 participants